[PATCH] replace hack with dget/mntget usage in fs/dcookies.c

This patch replaces manual incrementing of refcounters on dentry/mnt in fs/dcookie.c with calls to dget()/mntget().

Noticed this when tried to change logic in dget() and it began to oops.

Signed-Off-By: Alexey Kuznetsov <[email protected]>
Signed-Off-By: Pavel Emelianov <[email protected]>
Signed-Off-By: Kirill Korotaev <[email protected]>

Kirill

--- linux-2.6.8.1-t032/fs/dcookies.c.dget	2004-08-14 14:54:46.000000000 +0400
+++ linux-2.6.8.1-t032/fs/dcookies.c	2005-08-23 14:09:00.000000000 +0400
@@ -93,12 +93,10 @@ static struct dcookie_struct * alloc_dco
 	if (!dcs)
 		return NULL;
 
-	atomic_inc(&dentry->d_count);
-	atomic_inc(&vfsmnt->mnt_count);
 	dentry->d_cookie = dcs;
 
-	dcs->dentry = dentry;
-	dcs->vfsmnt = vfsmnt;
+	dcs->dentry = dget(dentry);
+	dcs->vfsmnt = mntget(vfsmnt);
 	hash_dcookie(dcs);
 
 	return dcs;

---

• Follow-Ups:
  • Re: [PATCH] replace hack with dget/mntget usage in fs/dcookies.c
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [patch 1/1] Hot plug CPU to support physical add of new processors (i386)
• Next by Date: Re: THE LINUX/I386 BOOT PROTOCOL - Breaking the 256 limit
• Previous by thread: [patch] drivers/ide/pci/alim15x3.c SMP fix
• Next by thread: Re: [PATCH] replace hack with dget/mntget usage in fs/dcookies.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]