Re: [PATCH] libata: add ATAPI module option

Mark Lord wrote:

Jeff Garzik wrote:

-#ifndef ATA_ENABLE_ATAPI
-    if (unlikely(dev->class == ATA_DEV_ATAPI))
-        return NULL;
-#endif
+    if (atapi_enabled) {
+        if (unlikely(dev->class == ATA_DEV_ATAPI))
+            return NULL;
+    }

..

Is that if-stmt the right way around?
At first glance, I'd expect it to read:

     if (!atapi_enabled) {
     ...

Cheers!

Indeed, thanks, fixed.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] libata: add ATAPI module option
    • From: Jeff Garzik <[email protected]>
  • Re: [PATCH] libata: add ATAPI module option
    • From: Mark Lord <[email protected]>

• Prev by Date: Re: KLive: Linux Kernel Live Usage Monitor
• Next by Date: jack, PREEMPT_DESKTOP, delayed interrupts?
• Previous by thread: Re: [PATCH] libata: add ATAPI module option
• Next by thread: [PATCH 1/1] Implement shared page tables
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]