Re: 2.6.13-rc7-rt3 compile fix

[Steven Rostedt <rostedt@goodmis.org>]

On Fri, 2005-08-26 at 16:17 -0500, K.R. Foley wrote:
> 2.6.13-rc7-rt3 won't compile without the simple patch below.
>  
-       __raw_spin_lock(old_owner->task->pi_lock);
+       __raw_spin_lock(&old_owner->task->pi_lock);
        TRACE_WARN_ON_LOCKED(plist_empty(&waiter->pi_list));
        TRACE_WARN_ON_LOCKED(lock_owner(lock));
 
@@ -683,7 +683,7 @@
        }
        TRACE_WARN_ON_LOCKED(1);
 ok:
-       __raw_spin_unlock(old_owner->task->pi_lock);
+       __raw_spin_unlock(&old_owner->task->pi_lock);
        return;


Oops! my bad.  I saw that needed locking, but I didn't have the tracing
on (I was trying for internal deadlocks), so that part of the code
wasn't compiling.  If you turn off tracing it would compile :-)

Anyway, the next time I modify code that's protected by ifdefs, I'll
change my config and see at least the code compiles.

Thanks,

-- Steve


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/