On Fri, 2005-08-26 at 13:52 -0400, John McCutchan wrote:
> Thanks for your suggestion, it has fixed the inotify problem. But where
> to put the fix is turning into a bit of a mess. Some callers like
> drivers/md/dm.c:682 call idr_get_new_above as if it will return >=
> starting_id. The comment says that it will return > starting_id, and the
> function name leads people to believe the same thing. In the patch below
> I change inotify do add one to the value was pass into idr. I also
> change the comment to more accurately reflect what the function does.
> The function name doesn't fit, but it never did.
>
> Signed-off-by: John McCutchan <[email protected]>
Signed-off-by: Robert Love <[email protected]>
Keeping the current behavior is probably the best way to go.
Robert Love
> Index: linux/fs/inotify.c
> ===================================================================
> --- linux.orig/fs/inotify.c 2005-08-26 13:38:29.000000000 -0400
> +++ linux/fs/inotify.c 2005-08-26 13:38:55.000000000 -0400
> @@ -353,7 +353,7 @@
> do {
> if (unlikely(!idr_pre_get(&dev->idr, GFP_KERNEL)))
> return -ENOSPC;
> - ret = idr_get_new_above(&dev->idr, watch, dev->last_wd, &watch->wd);
> + ret = idr_get_new_above(&dev->idr, watch, dev->last_wd+1, &watch->wd);
> } while (ret == -EAGAIN);
>
> return ret;
> Index: linux/lib/idr.c
> ===================================================================
> --- linux.orig/lib/idr.c 2005-08-26 13:38:22.000000000 -0400
> +++ linux/lib/idr.c 2005-08-26 13:39:08.000000000 -0400
> @@ -207,7 +207,7 @@
> }
>
> /**
> - * idr_get_new_above - allocate new idr entry above a start id
> + * idr_get_new_above - allocate new idr entry above or equal to a start id
> * @idp: idr handle
> * @ptr: pointer you want associated with the ide
> * @start_id: id to start search at
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
| |
 |