On Fri, 2005-08-26 at 09:18 +1000, Paul Mackerras wrote: > Benjamin Herrenschmidt writes: > > > Ok, so what is the problem then ? Why do we have to wait at all ? Why > > not just unplug/replug right away ? > > We'd have to be absolutely certain that the driver could not possibly > take another interrupt or try to access the device on behalf of the > old instance of the device by the time it returned from the remove > function. I'm not sure I'd trust most drivers that far... Hrm... If a driver gets that wrong, then it will also blow up when unloaded as a module. All drivers should be fully shut down by the time they return from remove(). free_irq() is synchronous as is iounmap() and both of those are usually called as part of remove(). I wouldn't be too worried here. Ben. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [patch 8/8] PCI Error Recovery: PPC64 core recovery routines
- From: Linas Vepstas <[email protected]>
- Re: [patch 8/8] PCI Error Recovery: PPC64 core recovery routines
- References:
- [patch 8/8] PCI Error Recovery: PPC64 core recovery routines
- From: Linas Vepstas <[email protected]>
- Re: [patch 8/8] PCI Error Recovery: PPC64 core recovery routines
- From: John Rose <[email protected]>
- Re: [patch 8/8] PCI Error Recovery: PPC64 core recovery routines
- From: Linas Vepstas <[email protected]>
- Re: [patch 8/8] PCI Error Recovery: PPC64 core recovery routines
- From: Paul Mackerras <[email protected]>
- Re: [patch 8/8] PCI Error Recovery: PPC64 core recovery routines
- From: Benjamin Herrenschmidt <[email protected]>
- Re: [patch 8/8] PCI Error Recovery: PPC64 core recovery routines
- From: Linas Vepstas <[email protected]>
- Re: [patch 8/8] PCI Error Recovery: PPC64 core recovery routines
- From: Benjamin Herrenschmidt <[email protected]>
- Re: [patch 8/8] PCI Error Recovery: PPC64 core recovery routines
- From: Paul Mackerras <[email protected]>
- [patch 8/8] PCI Error Recovery: PPC64 core recovery routines
- Prev by Date: Re: 2.6.13-rc7-rt1
- Next by Date: Re: [PATCH] drivers/hwmon/*: kfree() correct pointers
- Previous by thread: Re: [patch 8/8] PCI Error Recovery: PPC64 core recovery routines
- Next by thread: Re: [patch 8/8] PCI Error Recovery: PPC64 core recovery routines
- Index(es):
