Re: [PATCH] removes filp_count_lock and changes nr_files type to atomic_t

[Arjan van de Ven <arjan@infradead.org>]

> > 
> > this patch adds atomic ops where there were none before
> 
> nope... a spinlock/spinunlock contains atomic ops.

unlock usually doesn't but ok

> 
> > for those architectures that need atomics for read (parisc? arm?)
> 
> not today. No atomic needed for read.
> 
> > 
> > however.. wouldn't it be better to make this a per cpu variable for
> > write, and for read iterate or do something smart otherwise?
> 
> So on a machine with 256 CPUS, you want to iterate 256 counters ?

you can be smart about this, similar to what ext3 and others do for
similar counters


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/