Re: [PATCH] removes filp_count_lock and changes nr_files type to atomic_t

Christoph Hellwig a écrit :

On Thu, Aug 25, 2005 at 10:45:12AM +0200, Eric Dumazet wrote:

This patch assumes that atomic_read() is a plain {return v->counter;} on all architectures. (keywords : sysctl, /proc/sys/fs/file-nr, proc_dointvec)

But that's not true.  You need to write you own sysctl handler for it,
probably worth adding a generic atomic_t sysctl handler while you're
at it.

I checked linux-2.6.13-rc7 tree, and atomic_read() is just a wrapper to read v->counter.

In the ancient times, yes, atomic_read() was different on some archs, but not today.

Eric

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] removes filp_count_lock and changes nr_files type to atomic_t
    • From: Christoph Hellwig <[email protected]>

• References:
  • [patch] Additions to .data.read_mostly section
    • From: Ravikiran G Thirumalai <[email protected]>
  • Re: [patch] Additions to .data.read_mostly section
    • From: Arjan van de Ven <[email protected]>
  • [PATCH] removes filp_count_lock and changes nr_files type to atomic_t
    • From: Eric Dumazet <[email protected]>
  • Re: [PATCH] removes filp_count_lock and changes nr_files type to atomic_t
    • From: Christoph Hellwig <[email protected]>

• Prev by Date: Re: [PATCH 05/15] ia64: remove use of asm/segment.h
• Next by Date: Re: [PATCH] removes filp_count_lock and changes nr_files type to atomic_t
• Previous by thread: Re: [PATCH] removes filp_count_lock and changes nr_files type to atomic_t
• Next by thread: Re: [PATCH] removes filp_count_lock and changes nr_files type to atomic_t
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]