Hi, I'm currently implementing change notification support for the linux cifs client as part of Google's Summer of Code program. In cifs, change notification works pretty much the same as dnotify does in the kernel, and you cancel the notification by sending a NT_CANCEL request. According to the fcntl manual you can cancel a notification by doing fcntl(fd, F_NOTIFY, 0) (ie. sending 0 as the notification mask), but looking in the kernel code fcntl_dirnotify() immediately calls dnotify_flush() with neither telling the vfs module about it. Is there a reason for this? Otherwise I'd propose calling filp->f_op->dir_notify(filp, 0) at some point in this scenario. Regarding inotify, inotify_add_watch doesn't seem to pass on the request either, which works fine for local filesystem operations as they call fsnotify_* functions every time, but that isn't really feasible for filesystems like cifs because we'd have to request change notification on everything. Is there plans for implementing a mechanism to let vfs modules get watch requests too? cheers, Asser
Attachment:
pgpd5suLtRr9y.pgp
Description: PGP signature
- Follow-Ups:
- Re: dnotify/inotify and vfs questions
- From: Jamie Lokier <[email protected]>
- Re: dnotify/inotify and vfs questions
- Prev by Date: Re: [patch] suspend: update warnings
- Next by Date: Re: [patch] suspend: update warnings
- Previous by thread: [PATCH] blk queue io tracing support
- Next by thread: Re: dnotify/inotify and vfs questions
- Index(es):
