Re: PATCH for changing of DVD speed via ioctl() call

On Sun, Aug 21, 2005 at 09:56:45PM +0200, Bodo Eggert wrote:

> The parameter value should IMHO be a pointer to a struct {
>  unsigned long long maxspeed; // (with 0 being the magic max. value?)
>  int facility; /* 0=general speed, 2=general read, 4=read data,
>                   6=read audio, 8=read raw ... whatever is supported
>                   n+1 = s/read/write/ */
> }

Passing pointers inside ioctl's is horrible IMO and if we can avoid it
we should.  It's just asking for problems.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: PATCH for changing of DVD speed via ioctl() call
    • From: Bodo Eggert <[email protected]>

• References:
  • Re: PATCH for changing of DVD speed via ioctl() call
    • From: Bodo Eggert <[email protected]>

• Prev by Date: Re: New maintainer needed for the Linux smb filesystem
• Next by Date: Re: [RFC] [PATCH] cache pollution aware __copy_from_user_ll()
• Previous by thread: Re: PATCH for changing of DVD speed via ioctl() call
• Next by thread: Re: PATCH for changing of DVD speed via ioctl() call
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]