Re: use of uninitialized pointer in jffs_create()

[Alexey Dobriyan <adobriyan@gmail.com>]

On Sun, Aug 21, 2005 at 12:28:08AM +0200, Jesper Juhl wrote:
> gcc kindly pointed me at jffs_create() with this warning : 
> 
> fs/jffs/inode-v23.c:1279: warning: `inode' might be used uninitialized
> in this function

I don't see a warning with latest gcc-4.1 snapshot.

> And looking at the function :
> 
> static int
> jffs_create(struct inode *dir, struct dentry *dentry, int mode,
>                 struct nameidata *nd)
> {
>         struct jffs_raw_inode raw_inode;
>         struct jffs_control *c;
>         struct jffs_node *node;
>         struct jffs_file *dir_f; /* JFFS representation of the directory.  */
>         struct inode *inode;
>         int err;
> 
>         truncate_inode_pages(&inode->i_data, 0);

$ grep truncate_inode_pages -r fs/jffs/
$
	?

> I think it is correct. How on earth is that call to
> truncate_inode_pages() going to avoid blowing up? inode has not yet
> been initialized...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/