Re: [PATCH] fix dst_entry leak in icmp_push_reply()

Patrick McHardy wrote:

Ollie Wild wrote:
If the ip_append_data() call in icmp_push_reply() fails,ip_flush_pending_frames() needs to be called. Otherwise, ip_rt_put()is never called on inet_sk(icmp_socket->sk)->cork.rt, which preventsthe route (and net_device) from ever being freed.
Your patch doesn't fit your description, the else-condition you're
adding triggers when the queue is empty, so what is the point?

Since we're only calling ip_append_data() once here, the two conditionsare identical.


Ollie
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] fix dst_entry leak in icmp_push_reply()
  - From: Ollie Wild <[email protected]>
- Re: [PATCH] fix dst_entry leak in icmp_push_reply()
  - From: Patrick McHardy <[email protected]>

References:
- [PATCH] fix dst_entry leak in icmp_push_reply()
  - From: Ollie Wild <[email protected]>
- Re: [PATCH] fix dst_entry leak in icmp_push_reply()
  - From: Patrick McHardy <[email protected]>

Prev by Date: Re: [PATCH] add transport class symlink to device object
Next by Date: Re: 2.2.26 kernel on FC1
Previous by thread: Re: [PATCH] fix dst_entry leak in icmp_push_reply()
Next by thread: Re: [PATCH] fix dst_entry leak in icmp_push_reply()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind]