Uttered Adam Litke <[email protected]>, spake thus: > The line-wrapping in most of the include/asm/pgtable.h pte test/set > macros looks horrible in my 80 column terminal. The following "test the > waters" patch is how I would like to see them laid out. I realize that > the braces don't adhere to CodingStyle but the advantage is (when taking > wrapping into account) that the code takes up no additional space. How > do people feel about making this change? Any better suggestions? I > personally wouldn't like a lone closing brace like normal functions > because of the extra lines eaten. I volunteer to patch up the other > architectures if we reach a consensus. Congratulations for keeping your 80-column display. The coding standard assumes that and 8-character tabs for carefully thought-out software development reasons -- they are functional, not traditional. Since these are inline procedures, make them follow the coding standard; that's why we have one. Cheers
Attachment:
pgpVSzcTJ3Vuu.pgp
Description: PGP signature
- References:
- [RFC] Cleanup line-wrapping in pgtable.h
- From: Adam Litke <[email protected]>
- [RFC] Cleanup line-wrapping in pgtable.h
- Prev by Date: Re: [RFC] Cleanup line-wrapping in pgtable.h
- Next by Date: Re: Schedulers benchmark - Was: [ANNOUNCE][RFC] PlugSched-5.2.4 for 2.6.12 and 2.6.13-rc6
- Previous by thread: Re: [RFC] Cleanup line-wrapping in pgtable.h
- Next by thread: Re: [RFC] Cleanup line-wrapping in pgtable.h
- Index(es):
