Re: [PATCH 1/14] i386 / Make write ldt return error code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Andi Kleen ([email protected]) wrote:
> On Wed, Aug 10, 2005 at 09:52:51PM -0700, [email protected] wrote:
> > Xen requires error returns from the hypercall to update LDT entries,
> > and this generates completely equivalent code on native.
> 
> I don't think that is something we want. Nothing in the callers will check
> the errors anyways. If Xen has such a requirement it should kill
> the guest when it is violated, otherwise they will be ignored.

In this case the callers do propagate the error (unless you mean
userspace doesn't check return value from syscall, which is same problem
if copy_from_user failed, for example).  Xen has done some more wrapping
of the hypercalls to be effectively synchronous exceptions on error.
Keir, Ian, is that preferred method going forward?

thanks,
-chris
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]
  Powered by Linux