Re: [patch] inotify: idr_get_new_above not working?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2005-08-15 at 12:27 -0400, Robert Love wrote:
> On Mon, 2005-08-15 at 10:16 -0400, John McCutchan wrote:
> 
> > Inotify is using idr_get_new_above to make sure that the next watch
> > descriptor is larger/different than any of the previous watch
> > descriptors. We keep track of the largest wd that we get out of
> > idr_get_new_above, and pass that to idr_get_new_above. I have noticed
> > though, that idr_get_new_above always returns the first available id.
> > This causes a serious problem for inotify, because user space will get a
> > IGNORE event for a wd K that might refer to the last holder of the K.
> 
> Turns out that the problem was in our court and not the idr layer.
> idr_get_new_above() seems to work fine.
> 
> One-line patch is attached.  Please merge before 2.6.13.

My bad! Patch looks correct.

Signed-off-by: John McCutchan <[email protected]>


-- 
John McCutchan <[email protected]>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]
  Powered by Linux