[PATCH] broken error path in drivers/pnp/card.c

Hi all,

	it seems that the error path in pnp_request_card_device() is
broken (one variable is left initialized and the semaphore is not 
unlocked). The bellow patch should fix it.

Signed-off-by: Jaroslav Kysela <[email protected]>


diff --git a/drivers/pnp/card.c b/drivers/pnp/card.c
--- a/drivers/pnp/card.c
+++ b/drivers/pnp/card.c
@@ -312,6 +312,8 @@ found:
 	if (drv->link.driver.probe) {
 		if (drv->link.driver.probe(&dev->dev)) {
 			dev->dev.driver = NULL;
+			dev->card_link = NULL;
+			up_write(&dev->dev.bus->subsys.rwsem);
 			return NULL;
 		}
 	}

						Jaroslav

-----
Jaroslav Kysela <[email protected]>
Linux Kernel Sound Maintainer
ALSA Project, SUSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Prev by Date: Re: rc6 keeps hanging and blanking displays where rc4-mm1 works fine.
• Next by Date: Re: [PATCH] i386 No-Idle-Hz aka Dynamic-Ticks 3
• Previous by thread: Re: VIA VT6410 IDE support for 2.6.11-rc3/via82cxxx
• Next by thread: [PATCH] broken error path in drivers/pnp/card.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]