Re: [patch] unexport __mntput()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Coywolf Qi Hunt wrote:
Hello,

Unexport __mntput() was talked about two months ago. http://lkml.org/lkml/2005/6/9/69
Modules should not call __mntput() directly. If autofs or nfsd does that, it's
 being wrong.

I think you missed the point in the last discussion. __mntput is called from mntput(), which autofs and nfsd call. Their use is correct given what they do:

Autofs 3 and 4 use it for walking the vfsmount tree and determining if/when a mountpoint is ready to expire.

Nfsd uses it to serve up nfs exports that don't cross mountpoints (or do, if "crossmnt" is specified in /etc/exports.

Thanks,

Mike Waychison


		Coywolf


Signed-off-by: Coywolf Qi Hunt <[email protected]>
--- 2.6.13-rc6/fs/namespace.c~unexport-__mntput	2005-08-12 08:21:22.000000000 -0500
+++ 2.6.13-rc6/fs/namespace.c	2005-08-14 20:32:01.000000000 -0500
@@ -180,8 +180,6 @@
 	deactivate_super(sb);
 }
-EXPORT_SYMBOL(__mntput);
-
 /* iterator */
 static void *m_start(struct seq_file *m, loff_t *pos)
 {

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]
  Powered by Linux