Re: [patch][-mm] selinux: Reduce memory use by avtab

[Stephen Smalley <sds@tycho.nsa.gov>]

On Fri, 2005-08-12 at 00:34 +0400, Alexey Dobriyan wrote:
> On Thu, Aug 11, 2005 at 03:32:24PM -0400, Stephen Smalley wrote:
> > This patch improves memory use by SELinux by both reducing the avtab
> > node size and reducing the number of avtab nodes.
> 
> > +int avtab_read_item(void *fp, u32 vers, struct avtab *a,
> > +	            int (*insertf)(struct avtab *a, struct avtab_key *k,
> > +				   struct avtab_datum *d, void *p),
> > +		    void *p)
> > +{
> > +	u16 buf16[4],
> 
> __le16
> 
> > +	u32 buf32[7],
> 
> __le32
> 
> > +		items2 = le32_to_cpu(buf32[0]);
> 
> > +	key.source_type = le16_to_cpu(buf16[items++]);
> 
> > +static int cond_read_av_list(struct policydb *p, void *fp, struct cond_av_list **ret_list, struct cond_av_list *other)
> > +{
> 
> > +	u32 buf[1]
> 
> __le32
> 
> > +	len = le32_to_cpu(buf[0]);
> 
> Stephen, "[PATCH] selinux: endian annotations" you ACKed in June is hopelessly
> lost or thoroughly queued for inclusion?

Hmmm...sorry about that - I do have that patch, but seem to have failed
to follow up on it.  I'll make a patch relative to this one that fixes
up any sparse bitwise warnings unless you have a particular desire to
update your original one.  Should -Wbitwise be included in CHECKFLAGS in
the kernel Makefile by default?

-- 
Stephen Smalley
National Security Agency

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/