Re: BUG: Real-Time Preemption 2.6.13-rc5-RT-V0.7.52-16

[Daniel Walker <dwalker@mvista.com>]

On Wed, 2005-08-10 at 13:52 +0200, Ingo Molnar wrote:
> * Daniel Walker <dwalker@mvista.com> wrote:
> 
> > This may fix the warning , but I doubt it does anything for any hangs..
> > 
> > --- linux-2.6.12.orig/drivers/usb/core/hcd.c    2005-08-09 22:41:18.000000000 +0000
> > +++ linux-2.6.12/drivers/usb/core/hcd.c 2005-08-10 00:23:16.000000000 +0000
> > @@ -540,8 +540,7 @@ void usb_hcd_poll_rh_status(struct usb_h
> >         if (length > 0) {
> > 
> >                 /* try to complete the status urb */
> > -               local_irq_save (flags);
> > -               spin_lock(&hcd_root_hub_lock);
> > +               spin_lock_irqsave(&hcd_root_hub_lock, flags);
> >                 urb = hcd->status_urb;
> >                 if (urb) {
> >                         spin_lock(&urb->lock);
> 
> what -RT tree is this against? This change is already in the -16 tree.

It looks like it in the same function, only further down. The patch
above didn't add a "local_irq_save" , but there is one added in -16
around usb_hcd_giveback_urb()  .. 

Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/