Re: [Linux-parport] Incorrect permissions on parport sysctls.

[Dave Jones <davej@redhat.com>]

On Tue, Aug 09, 2005 at 11:11:10AM +0100, Tim Waugh wrote:
 > On Tue, Aug 09, 2005 at 12:44:41AM -0400, Dave Jones wrote:
 > 
 > > We have a bunch of 'probe' sysctl's in parport, which are
 > > readable. (world readable even). Make them write-only.
 > > Without this, sysctl -a will try to read these files.
 > 
 > ??
 > 
 > This change is wrong.  The probing happens at module load time, and
 > the IEEE 1284 device IDs are stored for later retrieval to user space
 > via these sysctls.
 > 
 > They are backed by read-only variables.  Reading does not trigger any
 > device interaction.
 > 
 > Make them 0400 if you think it's a security issue: but then,
 > /proc/ide/hda/model etc should also get the same treatment.

It wasn't a security related change.  As I mentioned above,
sysctl -a would fail to read them anyway when I last tried
(circa 2.6.9/10)

I'll try and reproduce without that patch later today.

		Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/