Quoting James Morris ([email protected]):
> On Mon, 8 Aug 2005, [email protected] wrote:
>
> This looks like a nice cleanup.
>
> > +
> > + if (count < 0 || count >= PAGE_SIZE)
> > + return -ENOMEM;
> > + if (*ppos != 0) {
> > + return -EINVAL;
> > + }
>
> Why is the first error there -ENOMEM and not -EINVAL?
Thanks James, that should be -EINVAL for both. For that matter, the
braces in the next line shouldn't be there. Obvious patch appended.
thanks,
-serge
Signed-off-by: Serge Hallyn <[email protected]>
--
seclvl.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
Index: linux-2.6.13-rc5-mm1/security/seclvl.c
===================================================================
--- linux-2.6.13-rc5-mm1.orig/security/seclvl.c 2005-08-08 17:22:45.000000000 -0500
+++ linux-2.6.13-rc5-mm1/security/seclvl.c 2005-08-09 13:45:31.000000000 -0500
@@ -252,10 +252,9 @@ passwd_write_file(struct file * file, co
}
if (count < 0 || count >= PAGE_SIZE)
- return -ENOMEM;
- if (*ppos != 0) {
return -EINVAL;
- }
+ if (*ppos != 0)
+ return -EINVAL;
page = (char *)get_zeroed_page(GFP_KERNEL);
if (!page)
return -ENOMEM;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
| |
 |