The `sig' variable in kernel/sys.c::sys_prctl() is completely redundant, we might as well get rid of it. Patch below for review (also attached since gmail's webmail interface will most certainly mangle the inline one). Signed-off-by: Jesper Juhl <[email protected]> --- --- linux-2.6.13-rc6/kernel/sys.c~ 2005-08-09 13:35:40.000000000 +0200 +++ linux-2.6.13-rc6/kernel/sys.c 2005-08-09 13:35:40.000000000 +0200 @@ -1711,7 +1711,6 @@ asmlinkage long sys_prctl(int option, un unsigned long arg4, unsigned long arg5) { long error; - int sig; error = security_task_prctl(option, arg2, arg3, arg4, arg5); if (error) @@ -1719,12 +1718,11 @@ asmlinkage long sys_prctl(int option, un switch (option) { case PR_SET_PDEATHSIG: - sig = arg2; - if (!valid_signal(sig)) { + if (!valid_signal(arg2)) { error = -EINVAL; break; } - current->pdeath_signal = sig; + current->pdeath_signal = arg2; break; case PR_GET_PDEATHSIG: error = put_user(current->pdeath_signal, (int __user *)arg2); -- Jesper Juhl <[email protected]> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html
Attachment:
sys_prctl.patch
Description: Binary data
- Follow-Ups:
- Re: [PATHC] remove redundant variable in sys_prctl
- From: Jesper Juhl <[email protected]>
- Re: [PATHC] remove redundant variable in sys_prctl
- Prev by Date: Re: [RFC][patch 0/2] mm: remove PageReserved
- Next by Date: Re: [OT] util-linux 2.13-pre1
- Previous by thread: query...
- Next by thread: Re: [PATHC] remove redundant variable in sys_prctl
- Index(es):
