obsolete modparam change busted.

[Dave Jones <davej@redhat.com>]

Circa 2.6.10, the module loader started barfing if
modprobe.conf contained obsolete parameters.

However this change was broken, and if the modprobe.conf
has trailing whitespace, modules fail to load with the
following helpful message..

snd_intel8x0: Unknown parameter `'

This ends up screwing over people who upgrade from previously
working configurations, so we've been backing out that change
in Fedora for a while with the patch below.

It doesn't look like the right thing to do, but it has got
things working again at least. Probably we should just check
explicity for whitespace and ignore it somewhere else in
the module loader.  Rusty?

		Dave


diff -urNp --exclude-from=/home/davej/.exclude linux-1503/kernel/module.c linux-1700/kernel/module.c
--- linux-1503/kernel/module.c
+++ linux-1700/kernel/module.c
@@ -1707,8 +1707,6 @@ static struct module *load_module(void _
 				 / sizeof(struct kernel_param),
 				 NULL);
 	}
-	if (err < 0)
-		goto arch_cleanup;
 
 	err = mod_sysfs_setup(mod, 
 			      (struct kernel_param *)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/