Re: [PATCH] ARCH_HAS_IRQ_PER_CPU avoids dead code in __do_IRQ()

[Ingo Oeser <ioe-lkml@rameria.de>]

Hi Karsten,

On Saturday 06 August 2005 18:14, Karsten Wiese wrote:
> From: Karsten Wiese <annabellesgarden@yahoo.de>
> 
> IRQ_PER_CPU is not used by all architectures.
> To avoid dead code generation in __do_IRQ()
> this patch introduces the macro ARCH_HAS_IRQ_PER_CPU.
> 
> ARCH_HAS_IRQ_PER_CPU is defined by architectures using
> IRQ_PER_CPU in their
> 	include/asm_ARCH/irq.h
> file.

Why not the other way around?

Just define IRQ_PER_CPU to 0 on architectures not needing it and
add a FAT comment there, that this disables it. Or make it a config option.

Then just leave the code as is and let GCC optimize the dead code
away without any changes in the C file. It works, I just checked it ;-)


Regards

Ingo Oeser

Attachment: pgpzpHhsm4VvF.pgp
Description: PGP signature