Re: [PATCH rc4-mm1] drivers/char/isicom.c old api rewritten

On 02/08/05 00:02 +0200, Jiri Slaby wrote:
> Hello.
> Could you send me critics and bugs?

You have much bigger chances of someone reviewing the patch if you
at least split code changes and whitespace/type cleanups. 65k is a lot.

> Could somebody test it (but NOT now)?
> Thanks.
> 
> drivers/char/isicom.c  | 1610 
> ++++++++++++++++++++++++-------------------------
> include/linux/isicom.h |    8
> 2 files changed, 817 insertions(+), 801 deletions(-)
> 
> Here it is (about 65 KiB):

It should deserve a few bytes of description ;-)

> http://www.fi.muni.cz/~xslaby/lnx/isi.txt
> 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH rc4-mm1] drivers/char/isicom.c old api rewritten
    • From: Jiri Slaby <[email protected]>

• References:
  • [PATCH rc4-mm1] drivers/char/isicom.c old api rewritten
    • From: Jiri Slaby <[email protected]>

• Prev by Date: Re: Outdated Sangoma Drivers
• Next by Date: Re: Freeing a dynamic struct cdev
• Previous by thread: Re: [PATCH rc4-mm1] drivers/char/isicom.c old api rewritten
• Next by thread: Re: [PATCH rc4-mm1] drivers/char/isicom.c old api rewritten
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]