Re: [PATCH] tpm_infineon: Support for new TPM 1.2 and PNPACPI

> +From/* read IO-ports from ACPI */
> +Frompnp_register_driver(&tpm_inf_pnp);
> +Frompnp_unregister_driver(&tpm_inf_pnp);

This seem very broken : in pnp unregister, pnp
will try to free the resource of the device, so you _can't_ safely use the
resource you probe after pnp_unregister_driver.
Please call pnp_unregister_driver in your remove routine.

Also mixing pnp and pci device is a very bad idea. You should try to
split it if you can.

Matthieu
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Prev by Date: Re: [PATCH 8/8] ALSA: convert kcalloc to kzalloc
• Next by Date: Re: [PATCH] kernel: use kcalloc instead kmalloc/memset
• Previous by thread: Re: [PATCH] tpm_infineon: Support for new TPM 1.2 and PNPACPI
• Next by thread: [PATCH] Keys: Fix key management syscall interface bugs
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]