Benjamin LaHaise <[email protected]> wrote:
>
> On Fri, Aug 05, 2005 at 05:36:29PM -0700, Andrew Morton wrote:
> > No, GFP_DMA should work OK. Except GFP_DMA doesn't have __GFP_VALID set.
> > It's strange that this didn't get noticed earlier.
> >
> > Ben, was there a reason for not giving GFP_DMA the treatment?
>
> Not really. Traditionally GFP_DMA was always mixed in with GFP_KERNEL or
> GFP_ATOMIC. It seems that GFP_DMA wasn't in the hunk of defines that all
> the other kernel flags were in, so if GFP_DMA is really valid all by itself,
> adding in the __GFP_VALID should be okay.
>
OK, it seems that pretty much all callers do remember to add GFP_KERNEL so
I guess we can treat this as a bug-which-ben's-patch-found and merge
Benoit's fix.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
| |
 |