[PATCH] Minor fix to kernel/workqueue.c

[mikukkon@miku.homelinux.net (Mika Kukkonen)]

With "-W -Wno-unused -Wno-sign-compare" I get the following compile warning:

  CC      kernel/workqueue.o
kernel/workqueue.c: In function `workqueue_cpu_callback':
kernel/workqueue.c:504: warning: ordered comparison of pointer with integer zero

On error create_workqueue_thread() returns NULL, not negative pointer
(duh!), so following trivial patch suggests itself.

Signed-off-by: Mika Kukkonen <mikukkon@gmail.com>

--- linux-2.6.orig/kernel/workqueue.c	2005-08-03 22:17:33.296479048 +0300
+++ linux-2.6/kernel/workqueue.c	2005-08-03 22:30:11.960984648 +0300
@@ -501,7 +501,7 @@
 	case CPU_UP_PREPARE:
 		/* Create a new workqueue thread for it. */
 		list_for_each_entry(wq, &workqueues, list) {
-			if (create_workqueue_thread(wq, hotcpu) < 0) {
+			if (!create_workqueue_thread(wq, hotcpu)) {
 				printk("workqueue for %i failed\n", hotcpu);
 				return NOTIFY_BAD;
 			}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/