Re: [PATCH] kernel: use kcalloc instead kmalloc/memset

Pekka Enberg <[email protected]> wrote:
>
> This patch converts kernel/ to use kcalloc instead of kmalloc/memset.
>

grr.
 
>  -	struct resource *res = kmalloc(sizeof(*res), GFP_KERNEL);
>  +	struct resource *res = kcalloc(1, sizeof(*res), GFP_KERNEL);

Notice how every conversion you did passes in `1' in the first argument?

And that's going to happen again and again and again.  Each callsite
needlessly passing that silly third argument, adding more kernel text.

If we're going to do this, we should add a two-arg helper function first,
and use that, no?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] kernel: use kcalloc instead kmalloc/memset
    • From: Pekka J Enberg <[email protected]>

• References:
  • [PATCH] kernel: use kcalloc instead kmalloc/memset
    • From: Pekka Enberg <[email protected]>

• Prev by Date: [PATCH] kernel: use kcalloc instead kmalloc/memset
• Next by Date: 2.6 select doesn't notify readablity of /proc/loadavg.
• Previous by thread: [PATCH] kernel: use kcalloc instead kmalloc/memset
• Next by thread: Re: [PATCH] kernel: use kcalloc instead kmalloc/memset
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]