[PATCH 2/2] Re: Major breakage in linux-git on x86_64, oom killer goes on rampage

Here's the x86_64 specific part.

The return value of handle_mm_fault() should be compared with symbolic
constants, not numbers.

Signed-off-by: Pavel Roskin <[email protected]>

diff --git a/arch/x86_64/mm/fault.c b/arch/x86_64/mm/fault.c
--- a/arch/x86_64/mm/fault.c
+++ b/arch/x86_64/mm/fault.c
@@ -439,15 +439,15 @@ good_area:
 	 * the fault.
 	 */
 	switch (handle_mm_fault(mm, vma, address, write)) {
-	case 1:
+	case VM_FAULT_MINOR:
 		tsk->min_flt++;
 		break;
-	case 2:
+	case VM_FAULT_MAJOR:
 		tsk->maj_flt++;
 		break;
-	case 0:
+	case VM_FAULT_SIGBUS:
 		goto do_sigbus;
-	default:
+	case VM_FAULT_OOM:
 		goto out_of_memory;
 	}
 

-- 
Regards,
Pavel Roskin

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Major breakage in linux-git on x86_64, oom killer goes on rampage
    • From: Pavel Roskin <[email protected]>
  • [PATCH 1/2] Re: Major breakage in linux-git on x86_64, oom killer goes on rampage
    • From: Pavel Roskin <[email protected]>

• Prev by Date: [PATCH 1/2] Re: Major breakage in linux-git on x86_64, oom killer goes on rampage
• Next by Date: Re: Calling suspend() in halt/restart/shutdown -> not a good idea
• Previous by thread: [PATCH 1/2] Re: Major breakage in linux-git on x86_64, oom killer goes on rampage
• Next by thread: Re: x86_64 access of some bad address
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]