Re: [UPDATE PATCH] push rounding up of relative request to schedule_timeout()

On 8/4/05, George Anzinger <[email protected]> wrote:
> Uh... PLEASE tell me you are NOT changing timespec_to_jiffies() (and
> timeval_to_jiffies() to add 1.  This is NOT the right thing to do.  For
> repeating times (see setitimer code) we need the actual time as we KNOW
> where the jiffies edge is in the repeating case.  The +1 is needed ONLY
> for the initial time, not the repeating time.

Please read the patch. I didn't touch timespec_to_jiffies() or
timeval_to_jiffies(). Not sure why you think I did. I agree that we
only need the initial time, my patch is no good. But it is hard for
non-itimers, like schedule_timeout() callers, to provide an interface
that only adds 1 to the initial request, since the callers currently
pass in an absolute jiffies value.

Thanks,
Nish
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- Re: [PATCH] Add schedule_timeout_{interruptible,uninterruptible}{,_msecs}() interfaces
  - From: Roman Zippel <[email protected]>
- Re: [PATCH] Add schedule_timeout_{interruptible,uninterruptible}{,_msecs}() interfaces
  - From: Nishanth Aravamudan <[email protected]>
- Re: [PATCH] Add schedule_timeout_{interruptible,uninterruptible}{,_msecs}() interfaces
  - From: Roman Zippel <[email protected]>
- Re: [PATCH] Add schedule_timeout_{interruptible,uninterruptible}{,_msecs}() interfaces
  - From: Nishanth Aravamudan <[email protected]>
- Re: [PATCH] Add schedule_timeout_{interruptible,uninterruptible}{,_msecs}() interfaces
  - From: Roman Zippel <[email protected]>
- [UPDATE PATCH] Add schedule_timeout_{intr,unintr}{,_msecs}() interfaces
  - From: Nishanth Aravamudan <[email protected]>
- Re: [UPDATE PATCH] Add schedule_timeout_{intr,unintr}{,_msecs}() interfaces
  - From: Roman Zippel <[email protected]>
- [PATCH] push rounding up of relative request to schedule_timeout()
  - From: Nishanth Aravamudan <[email protected]>
- [UPDATE PATCH] push rounding up of relative request to schedule_timeout()
  - From: Nishanth Aravamudan <[email protected]>
- Re: [UPDATE PATCH] push rounding up of relative request to schedule_timeout()
  - From: George Anzinger <[email protected]>

Prev by Date: Re: kexec and frame buffer
Next by Date: Re: [PATCH linux-2.6.13-rc3] SATA: rewritten sil24 driver
Previous by thread: Re: [UPDATE PATCH] push rounding up of relative request to schedule_timeout()
Next by thread: Re: [UPDATE PATCH] push rounding up of relative request to schedule_timeout()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind]