Re: [patch 2.6.13-rc4] fix get_user_pages bug

On Thu, 4 Aug 2005, Alexander Nyberg wrote:
> 
> Hardcoding is evil so it's good it gets cleaned up anyway.

Yes.

> > parisc, cris, m68k, frv, sh64, arm26 are also broken. Would you mind
> > resending a patch that fixes them all?
> 
> Remove the hardcoding in return value checking of handle_mm_fault()

I only saw this one when I had already done it myself.

Your arm26 conversion was only partial, btw. Notice how it returns the 
fault number (with a few extensions of its own) and processes it further? 
I think I got that right.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Re: [patch 2.6.13-rc4] fix get_user_pages bug
    • From: Linus Torvalds <[email protected]>
  • Re: [patch 2.6.13-rc4] fix get_user_pages bug
    • From: Hugh Dickins <[email protected]>
  • Re: [patch 2.6.13-rc4] fix get_user_pages bug
    • From: Linus Torvalds <[email protected]>
  • Re: [patch 2.6.13-rc4] fix get_user_pages bug
    • From: Hugh Dickins <[email protected]>
  • Re: [patch 2.6.13-rc4] fix get_user_pages bug
    • From: Linus Torvalds <[email protected]>
  • Re: [patch 2.6.13-rc4] fix get_user_pages bug
    • From: Hugh Dickins <[email protected]>
  • Re: [patch 2.6.13-rc4] fix get_user_pages bug
    • From: Nick Piggin <[email protected]>
  • Re: [patch 2.6.13-rc4] fix get_user_pages bug
    • From: Linus Torvalds <[email protected]>
  • Re: [patch 2.6.13-rc4] fix get_user_pages bug
    • From: Alexander Nyberg <[email protected]>
  • Re: [patch 2.6.13-rc4] fix get_user_pages bug
    • From: Nick Piggin <[email protected]>
  • Re: [patch 2.6.13-rc4] fix get_user_pages bug
    • From: Alexander Nyberg <[email protected]>

• Prev by Date: Re: [PATCH 1/2] cpqfc: fix for "Using too much stach" in 2.6 kernel
• Next by Date: Re: [ACPI] Re: [PATCH] PNPACPI: fix types when decoding ACPI resources [resend]
• Previous by thread: Re: [patch 2.6.13-rc4] fix get_user_pages bug
• Next by thread: Re: [patch 2.6.13-rc4] fix get_user_pages bug
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]