Re: [PATCH] 1/5 more-asm-cleanup

Zachary Amsden wrote:

Please explain why this is a reject after looking at the cpuid macro. It changed recently. Note 0 -> %ecx.

Then just use cpuid_eax(4)?  Or do those macros not behave that way?

Would you prefer that I call cpuid_count and pass an explicit zero parameter for ecx?

I guess I really don't like the implicit zero when it matters, so yes.

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] 1/5 more-asm-cleanup
    • From: [email protected]
  • Re: [PATCH] 1/5 more-asm-cleanup
    • From: "H. Peter Anvin" <[email protected]>
  • Re: [PATCH] 1/5 more-asm-cleanup
    • From: Zachary Amsden <[email protected]>

• Prev by Date: Re: [PATCH] IPMI driver update part 1, add per-channel IPMB addresses
• Next by Date: Re: [PATCH] IDE disks show invalid geometries in /proc/ide/hd*/geometry
• Previous by thread: Re: [PATCH] 1/5 more-asm-cleanup
• Next by thread: Re: [PATCH] 1/5 more-asm-cleanup
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]