Re: Re: [patch] net/tulip: LAN driver for ULI M5261/M5263

[Peer.Chen@uli.com.tw]

Resend the mail,Alexey,do you think anywhere else we need modify about the
source?
=============================================
Jeff:
I have removed the uli526x support from tulip core driver,check the patch
file for detail,thanks.
(See attached file: patchtulip)

Alexey:
Here the new patch,please check it, thanks.
(See attached file: patchuli526x)
I modify the source according to your suggestion except:
=====================================================
uli526x_init_one()
{
             struct net_device *dev;

             dev = alloc_etherdev(sizeof(*db));
             if (dev == NULL)
                         return -ENOMEM;

             [dev is dereferenced a couple of times]

             pci_set_drvdata(pdev, dev);
                         ...
}

> +                      pci_free_consistent(db->pdev, sizeof(struct
tx_desc) *
> +                                                          DESC_ALL_CNT +
0x20, db->desc_pool_ptr,
> +
db->desc_pool_dma_ptr);
> +                      pci_free_consistent(db->pdev, TX_BUF_ALLOC *
TX_DESC_CNT + 4,
> +
db->buf_pool_ptr, db->buf_pool_dma_ptr);
> +                      unregister_netdev(dev);
> +                      pci_release_regions(pdev);
> +                      free_netdev(dev);             /* free board
information */
> +                      pci_set_drvdata(pdev, NULL);
> +          }
=======================================================
I can not really get your meaning, could you give the explanation in
detail?

Best Regards
Peer

Attachment: patchtulip
Description: Binary data

Attachment: patchuli526x
Description: Binary data