Re: Fw: ati-remote strangeness from 2.6.12 onwards

[Pavel Machek <pavel@suse.cz>]

Hi!

> I discovered a minor change in 2.6.10-mm1, changing this value back
> corrects the "ok" button issue.
> 
> 
> diff -urN linux/drivers/usb/input/ati_remote.c
> linux-2.6.11/drivers/usb/input/ati_remote.c
> --- linux/drivers/usb/input/ati_remote.c        2005-08-02
> 17:56:26.000000000 +1200
> +++ linux-2.6.11/drivers/usb/input/ati_remote.c 2005-08-02
> 17:54:34.000000000 +1200
> @@ -263,7 +263,7 @@
>         {KIND_FILTERED, 0xe4, 0x1f, EV_KEY, KEY_RIGHT, 1},      /* right */
>         {KIND_FILTERED, 0xe7, 0x22, EV_KEY, KEY_DOWN, 1},       /* down */
>         {KIND_FILTERED, 0xdf, 0x1a, EV_KEY, KEY_UP, 1},         /* up */
> -       {KIND_FILTERED, 0xe3, 0x1e, EV_KEY, KEY_ENTER, 1},      /* "OK" */
> +       {KIND_FILTERED, 0xe3, 0x1e, EV_KEY, KEY_OK, 1},         /* "OK" */
>         {KIND_FILTERED, 0xce, 0x09, EV_KEY, KEY_VOLUMEDOWN, 1}, /* VOL + */
>         {KIND_FILTERED, 0xcd, 0x08, EV_KEY, KEY_VOLUMEUP, 1},   /* VOL - */
>         {KIND_FILTERED, 0xcf, 0x0a, EV_KEY, KEY_MUTE, 1},       /* MUTE  */

I'd say that KEY_ENTER is perhaps more logical there? It is certainly
more usefull than "OK" key.
								Pavel

-- 
teflon -- maybe it is a trademark, but it should not be.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/