Time conversion error in linux-2.6.11.10/net/sunrpoc/svcsock.c

Line 589 of linux-2.6.11.10/net/sunrpc/svcsock.c is obviously wrong:

                skb->stamp.tv_usec = xtime.tv_nsec * 1000;

To convert nsec to usec, one should divide instead of multiplying:

                skb->stamp.tv_usec = xtime.tv_nsec / 1000;

The same bug could be present in the latest kernels, although I haven't checked. This bug makes svc_udp_recvfrom() timestamps incorrect.

Sincerely,
Josip


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [PATCH] net/sunrpc: fix time conversion error
    • From: Nishanth Aravamudan <[email protected]>

• Prev by Date: [patch 1/8] x86_64: Reintroduce clustered_apic_check() for x86_64.
• Next by Date: Re: revert yenta free_irq on suspend
• Previous by thread: wakeup race checking for RT
• Next by thread: [PATCH] net/sunrpc: fix time conversion error
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]