* Steven Rostedt <[email protected]> wrote:
> On Mon, 2005-08-01 at 23:03 +0200, Ingo Molnar wrote:
> > * Steven Rostedt <[email protected]> wrote:
> >
> > > - struct semaphore stop;
> > > + struct compat_semaphore stop;
> >
> > i think it's policy->lock that is the issue here?
> >
>
> I was looking at Luca's original message where he showed the bug of
> -- drivers/char/watchdog/cpu5wdt.c: "cpu5wdt: Unknown symbol
> there_is_no_init_MUTEX_LOCKED_for_RT_semaphores") --
> Looking into this file the only init_MUTEX_LOCKED that I found was
>
> static int __devinit cpu5wdt_init(void)
> {
> unsigned int val;
> int err;
>
> [...]
>
> /* watchdog reboot? */
> val = inb(port + CPU5WDT_STATUS_REG);
> val = (val >> 2) & 1;
> if ( !val )
> printk(KERN_INFO PFX "sorry, was my fault\n");
>
> init_MUTEX_LOCKED(&cpu5wdt_device.stop);
> cpu5wdt_device.queue = 0;
>
> clear_bit(0, &cpu5wdt_device.inuse);
>
>
>
> Here I see that cpu5wdt_device.stop is being initialized with
> init_MUTEX_LOCKED, so that is what I went to fix. I even added the
> driver to my config and compiled it before sending it in. I don't
> have the device, but the driver compiled :-)
ok - the fix is in -52-10.
Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
| |
 |