Re: [PATCH linux-2.6-block:master] block: fix cfq_find_next_crq

On Tue, Jul 26 2005, Tejun Heo wrote:
>  Hi,
> 
>  In cfq_find_next_crq(), when determining rbnext, if
> rb_next(&last->rb_node) is NULL, rb_first() is used without checking
> if it equals last.  If it equals last, rbnext should be NULL not last.
> This bug is masked by duplicate calls to cfq_find_next_crq which ends
> up clearing cfqq->next_crq as, on the second call, last isn't on rb
> tree.
> 
>  This patch fixes cfq_find_next_crq() and removes extra calls to
> cfq_update_next_crq().

Thanks, looks good!

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH linux-2.6-block:master] block: fix cfq_find_next_crq
    • From: Tejun Heo <[email protected]>

• Prev by Date: Re: [PATCH linux-2.6-block:master] block: fix try_module_get race in elevator_find
• Next by Date: 2.6VMM, uClinux, & Comedi
• Previous by thread: [PATCH linux-2.6-block:master] block: fix cfq_find_next_crq
• Next by thread: [PATCH linux-2.6-block:master 00/05] blk: generic dispatch queue
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]