Re: [patch 2.6.13-rc4] fix get_user_pages bug

• To: Ingo Molnar <[email protected]>
• Subject: Re: [patch 2.6.13-rc4] fix get_user_pages bug
• From: Nick Piggin <[email protected]>
• Date: Mon, 01 Aug 2005 19:27:26 +1000
• Cc: Robin Holt <[email protected]>, Andrew Morton <[email protected]>, Linus Torvalds <[email protected]>, Roland McGrath <[email protected]>, Hugh Dickins <[email protected]>, [email protected], linux-kernel <[email protected]>
• Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com.au; h=Received:Message-ID:Date:From:User-Agent:X-Accept-Language:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=BuzUnp6ElT8Dxuu301Jy8W5LOzyRZMQEu0SIC3RxtZ6vJ9/1cQ3/6H/2TqRc44Xp+FDJJS1ultV2qNQhv/CtAwrRWqwjRY+flpZsOvFYW5DXnfuD95RuShbrdY2NN9PQmjnjDiusLhTU6MA3RQdR4ZLDYhuf8DcZl9WKl+OGlyg= ;
• In-reply-to: <[email protected]>
• References: <[email protected]> <[email protected]> <[email protected]>
• Sender: [email protected]
• User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20050513 Debian/1.7.8-1

Ingo Molnar wrote:

* Nick Piggin <[email protected]> wrote:

Feedback please, anyone.

it looks good to me, but wouldnt it be simpler (in terms of patch and architecture impact) to always retry the follow_page() in get_user_pages(), in case of a minor fault? The sequence of minor faults

I believe this can break some things. Hugh posted an example
in his recent post to linux-mm (ptrace setting a breakpoint
in read-only text). I think?

--
SUSE Labs, Novell Inc.

Send instant messages to your online friends http://au.messenger.yahoo.com -

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch 2.6.13-rc4] fix get_user_pages bug
    • From: Ingo Molnar <[email protected]>

• References:
  • [patch 2.6.13-rc4] fix get_user_pages bug
    • From: Nick Piggin <[email protected]>
  • Re: [patch 2.6.13-rc4] fix get_user_pages bug
    • From: Ingo Molnar <[email protected]>

• Prev by Date: Re: [patch 2.6.13-rc4] fix get_user_pages bug
• Next by Date: Re: 2.6.12 hangs on boot
• Previous by thread: Re: [patch 2.6.13-rc4] fix get_user_pages bug
• Next by thread: Re: [patch 2.6.13-rc4] fix get_user_pages bug
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]