Re: [2.6 patch] add -Werror-implicit-function-declaration to CFLAGS

[Adrian Bunk <bunk@stusta.de>]

On Sat, Jul 30, 2005 at 11:08:00AM -0700, Andrew Morton wrote:
> Adrian Bunk <bunk@stusta.de> wrote:
> >
> > Currently, using an undeclared function gives a compile warning, but it 
> > can lead to a link or even a runtime error.
> > 
> > With -Werror-implicit-function-declaration, we are getting an immediate 
> > compile error instead.
> > 
> > This patch also removes some unneeded spaces between two tabs in the 
> > following line.
> > 
> > 
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> > 
> > --- linux-2.6.13-rc3-mm3-full/Makefile.old	2005-07-30 13:55:32.000000000 +0200
> > +++ linux-2.6.13-rc3-mm3-full/Makefile	2005-07-30 13:55:56.000000000 +0200
> > @@ -351,7 +351,8 @@
> >  CPPFLAGS        := -D__KERNEL__ $(LINUXINCLUDE)
> >  
> >  CFLAGS 		:= -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
> > -	  	   -fno-strict-aliasing -fno-common \
> > +		   -Werror-implicit-function-declaration \
> > +		   -fno-strict-aliasing -fno-common \
> >  		   -ffreestanding
> >  AFLAGS		:= -D__ASSEMBLY__
> >  
> 
> heh.  Nice idea, but if I merge this I'll have tons of monkey work to do
> to get ppc64, ia64 and others compiling :(

Looking at Jan's defconfig builds [1], I don't see this.

> umm, so what to do?  I'm inclined to just slam it in post-2.6.13 then take
> a week off or something.



cu
Adrian

[1] http://l4x.org/k/

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/