Re: file kernel/signal.c, 2 * array subscript out of range

["Randy.Dunlap" <rdunlap@xenotime.net>]

On Sat, 30 Jul 2005 08:17:48 +0000 d binderman wrote:

> Hello there,
> 
> I just tried to compile Redhat Fedora package
> kernel-2.6.12-1.1435_FC5 with the Intel C compiler version 8.1
> 
> The compiler said
> 
> kernel/signal.c(196): warning #175: subscript out of range
> 
> The source code is
> 
>         case 4: ready  = signal->sig[3] &~ blocked->sig[3];
> 
> Clearly broken code. Array sig has only _NSIG_WORDS elements,
> which is set to two on this architecture.

so that line (case 4, where 4 is _NSIG_WORDS) won't ever be
executed on this arch...

This is arch-independent code and it handles a variety of
values for _NSIG_WORDS.  I don't see a problem.

On "this architecture," case 2: will be executed:

	case 2: ready  = signal->sig[1] &~ blocked->sig[1];
		ready |= signal->sig[0] &~ blocked->sig[0];
		break;

> Suggest rework code to use _NSIG_WORDS as the upper limit, not
> a fixed constant.
> 
> The compiler also said
> 
> kernel/signal.c(197): warning #175: subscript out of range
> 
> on the next line of source code.


---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/