Re: [PATCH] x86_64: sync_tsc fix the race (so we can boot)

[ebiederm@xmission.com (Eric W. Biederman)]

yhlu <yhlu.kernel@gmail.com> writes:

> if using you patch, the
> "synchronized TSC with CPU" never come out.
>
> then with your patch, I add back patch that moving set callin_map from
> smp_callin to start_secondary. It told me can not inquire the apic for
> the CPU 1....2....

Hmm.  You didn't post enough of a boot log for me to see the problem.
Does it boot and you don't see the message or is it something
else.

> Can we put tsc_sync_wait() back to smp_callin?
> 
> So that it will be executed serially and we can get
> "synchronized TSC with CPU"?

Currently that just seems silly.  That code should be async
safe.

But it sounds like you have some weird bug I don't understand.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/