Re: [PATCH] mm/slab.c : prefetchw the start of new allocated objects

* Eric Dumazet <[email protected]> wrote:

>  	local_irq_restore(save_flags);
>  	objp = cache_alloc_debugcheck_after(cachep, flags, objp, __builtin_return_address(0));
> +	prefetchw(objp);
>  	return objp;

the idea is good, but i'd suggest to do the prefetchw a bit earlier, 
right where we calculate objp. Furthermore, it might make sense to only 
trigger the prefetchw in the alloc-miss (non-per-CPU cache) case. There 
it's almost surely a win, in the per-CPU cache case it's not always.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • 2.6.12 sound problem
    • From: Stephen Clark <[email protected]>
  • Re: 2.6.12 sound problem
    • From: Takashi Iwai <[email protected]>
  • Re: 2.6.12 sound problem
    • From: Stephen Clark <[email protected]>
  • Re: 2.6.12 sound problem
    • From: Andrew Morton <[email protected]>
  • [PATCH] mm/slab.c : prefetchw the start of new allocated objects
    • From: Eric Dumazet <[email protected]>

• Prev by Date: [patch 3/8] Corgi Keyboard: Code tidying
• Next by Date: [patch 4/8] Corgi Touchscreen: Allow the driver to share the PMU
• Previous by thread: Re: [PATCH] mm/slab.c : prefetchw the start of new allocated objects
• Next by thread: Re: [PATCH] mm/slab.c : prefetchw the start of new allocated objects
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]