Re: include-linux-blkdevh-extern-inline-static-inline.patch added to -mm tree

[Coywolf Qi Hunt <coywolf@gmail.com>]

On 7/29/05, akpm@osdl.org <akpm@osdl.org> wrote:
> 
> The patch titled
> 
>      include/linux/blkdev.h: "extern inline" -> "static inline"
> 
> has been added to the -mm tree.  Its filename is
> 
>      include-linux-blkdevh-extern-inline-static-inline.patch
> 

...

> 
> 
> From: Adrian Bunk <bunk@stusta.de>
> 
> "extern inline" doesn't make much sense.

"extern inline" does make sense, and it does make sense here. please
backout this patch. Hint: the address of block_size() is referenced.

> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> ---
> 
>  include/linux/blkdev.h |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN include/linux/blkdev.h~include-linux-blkdevh-extern-inline-static-inline include/linux/blkdev.h
> --- devel/include/linux/blkdev.h~include-linux-blkdevh-extern-inline-static-inline      2005-07-28 19:28:05.000000000 -0700
> +++ devel-akpm/include/linux/blkdev.h   2005-07-28 19:28:05.000000000 -0700
> @@ -727,7 +727,7 @@ static inline unsigned int blksize_bits(
>         return bits;
>  }
> 
> -extern inline unsigned int block_size(struct block_device *bdev)
> +static inline unsigned int block_size(struct block_device *bdev)
>  {
>         return bdev->bd_block_size;
>  }



-- 
Coywolf Qi Hunt
http://ahbl.org/~coywolf/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/