Re: [PATCH] disk quotas fail when /etc/mtab is symlinked to /proc/mounts

[Mark Bellon <mbellon@mvista.com>]

If /etc/mtab is a regular file all of the mount options (of a file 
system) are written to /etc/mtab by the mount command. The quota tools 
look there for the quota strings for their operation. If, however, 
/etc/mtab is a symlink to /proc/mounts (a "good thing" in some 
environments)  the tools don't write anything - they assume the kernel 
will take care of things.

While the quota options are sent down to the kernel via the mount system 
call and the file system codes handle them properly unfortunately there 
is no code to echo the quota strings into /proc/mounts and the quota 
tools fail in the symlink case.

The attached patchs modify the EXT[2|3] and JFS codes to add the 
necessary hooks. The show_options function of each file system in these 
patches currently deal with only those things that seemed related to 
quotas; especially in the EXT3 case more can be done (later?).

The original XFS change has been dropped as per Nathan Scott 
<nathans@sgi.com>. The functionality had already been added.

The EXT3 has added error checking and has two minor changes:
  The "quota" option is considered part of the older style quotas
  Journalled quotas and older style quotas are mutually exclusive.
  - both discussable topics

mark

Signed-off-by: Mark Bellon <mbellon@mvista.com>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/