Re: PCI: fix up errors after dma bursting patch and CONFIG_PCI=n -- bug?

[Kumar Gala <kumar.gala@freescale.com>]

On Jul 26, 2005, at 12:50 PM, Greg KH wrote:

> On Mon, Jul 25, 2005 at 11:52:43PM -0500, Kumar Gala wrote:
>
> > Andrew,
> >
> > In the patch from:
> >
> > http://www.uwsg.iu.edu/hypermail/linux/kernel/0506.3/0985.html
> >
> > Is the the following line suppose inside the if CONFIG_PCI=n
> >
> >   #define pci_dma_burst_advice(pdev, strat, strategy_parameter) do  
> > { }
> while (0)
>
> > Signed-off-by: Kumar Gala <kumar.gala@freescale.com>
>
> Hm, how did that work?

I'm somewhat baffled by that as well.  I did a full build regression  
of the 50 PPC32 defconfigs and only one broke because of this.  I'm  
still a bit confused as to why.

> Bah, that pci.h file needs some major cleanups, I'll apply this patch
> and clean up the rest to make it more sane.

Cool, just want to make sure the minor fix makes it to linus before  
2.6.13.

- kumar
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/