machine_power_off on i386 and x86_64 now switch to the boot cpu out of paranoia and because the MP Specification indicates it is a good idea on reboot, so for those architectures it is a noop. I can't see anything in the acpi spec that requires you to be on the boot cpu to power off the system, so this should not be an issue for ia64. In addition ia64 has the altix a massive multi-node system where switching to the boot cpu sounds insane as we may hot removed the boot cpu. Signed-off-by: Eric W. Biederman <ebiederm@xmission.com> --- drivers/acpi/sleep/poweroff.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) c4ca5713b37cce7fcfdb8f212c789b552fc55e6f diff --git a/drivers/acpi/sleep/poweroff.c b/drivers/acpi/sleep/poweroff.c --- a/drivers/acpi/sleep/poweroff.c +++ b/drivers/acpi/sleep/poweroff.c @@ -54,7 +54,6 @@ void acpi_power_off(void) acpi_sleep_prepare(ACPI_STATE_S5); local_irq_disable(); /* Some SMP machines only can poweroff in boot CPU */ - set_cpus_allowed(current, cpumask_of_cpu(0)); acpi_enter_sleep_state(ACPI_STATE_S5); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- [PATCH 23/23] acpi: Don't call acpi_sleep_prepare from acpi_power_off
- From: ebiederm@xmission.com (Eric W. Biederman)
- [PATCH 23/23] acpi: Don't call acpi_sleep_prepare from acpi_power_off
- References:
- [PATCH 0/23] reboot-fixes
- From: ebiederm@xmission.com (Eric W. Biederman)
- [PATCH 2/23] Refactor sys_reboot into reusable parts
- From: ebiederm@xmission.com (Eric W. Biederman)
- [PATCH 3/23] Make ctrl_alt_del call kernel_restart to get a proper reboot.
- From: ebiederm@xmission.com (Eric W. Biederman)
- [PATCH 4/23] Add emergency_restart()
- From: ebiederm@xmission.com (Eric W. Biederman)
- [PATCH 5/23] Fix the arguments to machine_restart on cris
- From: ebiederm@xmission.com (Eric W. Biederman)
- [PATCH 6/23] Don't export machine_restart, machine_halt, or machine_power_off.
- From: ebiederm@xmission.com (Eric W. Biederman)
- [PATCH 7/23] i386: Implement machine_emergency_reboot
- From: ebiederm@xmission.com (Eric W. Biederman)
- [PATCH 8/23] x86_64: Fix reboot_force
- From: ebiederm@xmission.com (Eric W. Biederman)
- [PATCH 9/23] x86_64: Implemenent machine_emergency_restart
- From: ebiederm@xmission.com (Eric W. Biederman)
- [PATCH 10/23] Use kernel_power_off in sysrq-o
- From: ebiederm@xmission.com (Eric W. Biederman)
- [PATCH 11/23] Call emergency_reboot from panic
- From: ebiederm@xmission.com (Eric W. Biederman)
- [PATCH 12/23] Update sysrq-B to use emergency_restart()
- From: ebiederm@xmission.com (Eric W. Biederman)
- [PATCH 13/23] Fix watchdog drivers to call emergency_reboot()
- From: ebiederm@xmission.com (Eric W. Biederman)
- [PATCH 14/23] In hangcheck-timer.c call emergency_restart()
- From: ebiederm@xmission.com (Eric W. Biederman)
- [PATCH 15/23] 68328serial: sysrq should use emergency_reboot
- From: ebiederm@xmission.com (Eric W. Biederman)
- [PATCH 16/23] swpsuspend: Have suspend to disk use factors of sys_reboot
- From: ebiederm@xmission.com (Eric W. Biederman)
- [PATCH 17/23] pcwd.c: Call kernel_power_off not machine_power_off
- From: ebiederm@xmission.com (Eric W. Biederman)
- [PATCH 18/23] machine_shutdown: Typo fix to actually allow specifying which cpu to reboot on
- From: ebiederm@xmission.com (Eric W. Biederman)
- [PATCH 19/23] i386 machine_power_off cleanup
- From: ebiederm@xmission.com (Eric W. Biederman)
- [PATCH 20/23] APM: Remove redundant call to set_cpus_allowed
- From: ebiederm@xmission.com (Eric W. Biederman)
- [PATCH 21/23] x86_64 sync machine_power_off with i386
- From: ebiederm@xmission.com (Eric W. Biederman)
- [PATCH 0/23] reboot-fixes
- Prev by Date: Re: [2.6 patch] schedule obsolete OSS drivers for removal
- Next by Date: [PATCH 23/23] acpi: Don't call acpi_sleep_prepare from acpi_power_off
- Previous by thread: [PATCH 21/23] x86_64 sync machine_power_off with i386
- Next by thread: [PATCH 23/23] acpi: Don't call acpi_sleep_prepare from acpi_power_off
- Index(es):
