Hi Dave, Hi Evgeniy, the following patch fixes the illegal use of NETLINK_NFLOG by the 1wire drivers. It assumes that the netlink tap families can now safely be reclaimed, which is the case according to Dave at netconf'05. I'm not sure who would be the right person to fix this, but this patch needs to go into both 2.6.12.x and 2.6.13 trees, since it potentially causes a security problem by preventing the iptables ULOG This has been the third new piece of code that reuses NETLINK_NFLOG within a couple of months. I would really appreciate if people would actually ask/apply for a new protocol number instead of just overloading existing values and thereby causing breakage. Thanks, Harald -- - Harald Welte <[email protected]> http://netfilter.org/ ============================================================================ "Fragmentation is like classful addressing -- an interesting early architectural error that shows how much experimentation was going on while IP was being designed." -- Paul Vixie
Give the 1-wire driver stack its own netlink protocol number, instead of overloading NETLINK_NFLOG. I wonder what I have done to people, that they always overload the NETLINK_NFLOG protocol number and thereby effectively prevent the packet filter logging mechanism. Please don't re-use protocol numbers. Signed-off-by: Harald Welte <[email protected]> --- commit b4a566c332048b642506eff7de825fce710ff42c tree 07ef162f6d449dd67c586c9c63680004787b86c5 parent d5d3fb40b6db511dbd47a84634a1249de6b7b297 author laforge <[email protected]> Sa, 23 Jul 2005 08:41:24 -0400 committer laforge <[email protected]> Sa, 23 Jul 2005 08:41:24 -0400 drivers/w1/w1_int.c | 4 ++-- include/linux/netlink.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/w1/w1_int.c b/drivers/w1/w1_int.c --- a/drivers/w1/w1_int.c +++ b/drivers/w1/w1_int.c @@ -88,10 +88,10 @@ static struct w1_master * w1_alloc_dev(u dev->groups = 23; dev->seq = 1; - dev->nls = netlink_kernel_create(NETLINK_NFLOG, NULL); + dev->nls = netlink_kernel_create(NETLINK_W1, NULL); if (!dev->nls) { printk(KERN_ERR "Failed to create new netlink socket(%u) for w1 master %s.\n", - NETLINK_NFLOG, dev->dev.bus_id); + NETLINK_W1, dev->dev.bus_id); } err = device_register(&dev->dev); diff --git a/include/linux/netlink.h b/include/linux/netlink.h --- a/include/linux/netlink.h +++ b/include/linux/netlink.h @@ -20,7 +20,7 @@ #define NETLINK_IP6_FW 13 #define NETLINK_DNRTMSG 14 /* DECnet routing messages */ #define NETLINK_KOBJECT_UEVENT 15 /* Kernel messages to userspace */ -#define NETLINK_TAPBASE 16 /* 16 to 31 are ethertap */ +#define NETLINK_W1 16 /* 16 to 31 are ethertap */ #define MAX_LINKS 32
Attachment:
pgpnusYU5fFGu.pgp
Description: PGP signature
- Follow-Ups:
- Re: [PATCH] 1 Wire drivers illegally overload NETLINK_NFLOG
- From: Evgeniy Polyakov <[email protected]>
- Re: [PATCH] 1 Wire drivers illegally overload NETLINK_NFLOG
- From: YOSHIFUJI Hideaki / 吉藤英明 <[email protected]>
- Re: [PATCH] 1 Wire drivers illegally overload NETLINK_NFLOG
- Prev by Date: Re: HPT370 errors under 2.6.13-rc3-mm1
- Next by Date: Re: [PATCH] 1 Wire drivers illegally overload NETLINK_NFLOG
- Previous by thread: HPT370 errors under 2.6.13-rc3-mm1
- Next by thread: Re: [PATCH] 1 Wire drivers illegally overload NETLINK_NFLOG
- Index(es):
