Re: [announce] 'patchview' script

[Nick Wilson <njw@osdl.org>]

On Tue, Jul 19, 2005 at 11:51:03AM -0700, randy_dunlap wrote:
> 
> Hi,
> 
> Someone asked me about a tool like this and I didn't know of one,
> so I made this little script.
> 
> 'patchview' merges a patch file and a source tree to a set of
> temporary modified files.  This enables better patch (re)viewing
> and more viewable context.  (hopefully)
> 
> Are there already other tools that do something similar to this?
> (other than SCMs)
> 
> 
> The patchview script is here:
>   http://www.xenotime.net/linux/scripts/patchview

Hey Randy,

The mktemp command fails for me, but patchview keeps on going.

[njw@njw ~/tmp]$ patchview mypatch.patch linux-2.6.13-rc3
mktemp: cannot make temp dir /home/njw/tmp/XXXXXX/tmp.xV1xRT: No such file or directory
failed mktemp for patch files dir.
mkdir: cannot create directory `/fs': Permission denied
cp: cannot create regular file `/fs/Kconfig': No such file or directory
mkdir: cannot create directory `/fs': Permission denied
cp: cannot create regular file `/fs/Makefile': No such file or directory
[ ... ]


This patch makes mktemp work correctly for me and causes patchview to exit
if it happens to fail.

Thanks,

Nick Wilson

--- patchview.orig	2005-07-19 12:50:20.000000000 -0700
+++ patchview	2005-07-19 13:07:12.000000000 -0700
@@ -48,7 +48,7 @@
 else
 	TMPDIR=/tmp
 fi
-WORKDIR=`mktemp -d -p ${TMPDIR}/XXXXXX` || echo "failed mktemp for patch files dir."
+WORKDIR=`mktemp -d -p ${TMPDIR} XXXXXX` || { echo "failed mktemp for patch files dir."; exit 1; }
 
 pfiles=`lsdiff --strip 1 $patchfile`
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/