Re: [PATCH] jsm driver - Linux-2.6.12.3

[Alexey Dobriyan <adobriyan@gmail.com>]

On Tue, Jul 19, 2005 at 12:53:20PM -0500, V. ANANDA KRISHNAN wrote:
> This patch takes care of (1) compiler warnings which displays the mixing
> of declarations and code

With what gcc version and what CFLAGS?

> (2) dynamic allocation of major device number
> instead of the static number 253 (3) the version update to reflect the
> changes in the patch.

> --- linux-2.6.12.3.orig/drivers/serial/jsm/jsm_driver.c
> +++ linux-2.6.12.3.new/drivers/serial/jsm/jsm_driver.c

> + * CHANGE LOG:
> + * Jul 18, 2005: Changed the major number changed to 0 to use the dynamic
> + *	allocation of major number by OS.
> + *

ChangeLog maintenance is the job of SCM. Don't add useless comments.

> --- linux-2.6.12.3.orig/drivers/serial/jsm/jsm_neo.c
> +++ linux-2.6.12.3.new/drivers/serial/jsm/jsm_neo.c

> -	u8 ier = readb(&ch->ch_neo_uart->ier);
> -	u8 efr = readb(&ch->ch_neo_uart->efr);
> +	u8 ier, efr;
> +	ier = readb(&ch->ch_neo_uart->ier);
> +	efr = readb(&ch->ch_neo_uart->efr);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/