Rolf Eike Beer napsal(a):
Jiri Slaby wrote:
Kernel version: 2.6.13-rc3-git4
* This patch removes from kernel tree pci_find_device and changes
it with pci_get_device. Next, it adds pci_dev_put, to decrease reference
count of the variable.
* Next, there are some (about 10 or so) gcc warning problems (i. e.
variable may be unitialized) solutions, which were around code with old
pci_find_device.
Is this the reason why you initialize members of static structs? If this is
uninitialized it will end in the bss section and will be zeroed before the
kernel uses is. If you do it will go into data section and add more bloat to
the binary. At least this is the explanation I got once why not to do this.
I can't find now changes of initialization static variables, but i have
deleted section
dealing up with gcc warning from patch, it would go on a queue later.
Many of the callers of pci_find_device() look like they are not ported to the
2.6 driver API and do the scanning for devices themself. I think it would be
a good idea to try to convert them to the new driver model instead of
replacing this. When you mark this deprecated and they still use the old
function everyone using this will see that there is some work to do.
I don't know now the difference between API accurately, but I'll study
it in a few days
and delete this sections from patch, alternatively rewrite the code.
* Some code was unpretty, or ugly, so the patch provides more readable
code, in some cases.
If you try to beautify code then please use for_each_pci_dev() macro from
include/linux/pci.h where possible.
Done.
When you want something of this getting included you have to split that into
pieces. Use extra patches for changes in coding style and functionality.
Yeah, the patch now provides only changes of pci_find problems.
[Gcc will be discussed later, after doing more changes and completing patch
against gcc 4, where are more warnings...]
OK. The new patch is:
http://www.fi.muni.cz/~xslaby/lnx/lnx-pci_find-2.6.13-r3g4_1.patch
and bzipped
http://www.fi.muni.cz/~xslaby/lnx/lnx-pci_find-2.6.13-r3g4_1.patch.bz2
[Kernel version is the same (2.6.13-rc3-git4)]
And the patch now contains only:
* This patch removes from kernel tree pci_find_device and changes
it with pci_get_device. Next, it adds pci_dev_put, to decrease reference
count of the variable.
* Some code was unpretty, or ugly, so the patch provides more readable
code, in some cases.
* Marks the function (pci_find_device) as deprecated in pci.h
--
Jiri Slaby www.fi.muni.cz/~xslaby
~\-/~ [email protected] ~\-/~
241B347EC88228DE51EE A49C4A73A25004CB2A10
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
| |
 |